Stop running clang-tidy on torch/csrc/generic/*.cpp. #46335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those files are never directly built, only included in other files.
💊 CI failures summary and remediationsAs of commit f8303f5 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
|
See #46329 as an example where the clang_tidy run looks bogus. |
💊 CI failures summary and remediationsAs of commit f8303f5 (more details on the Dr. CI page):
3 failures not recognized by patterns:
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet: This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Oct 15, 2020
Summary: Those files are never directly built, only included in other files. Pull Request resolved: pytorch#46335 Reviewed By: albanD Differential Revision: D24316737 Pulled By: gchanan fbshipit-source-id: 67bb95e7f4450e3bbd0cd54f15fde9b6ff177479
This was referenced Oct 15, 2020
gchanan
added a commit
that referenced
this pull request
Oct 15, 2020
Summary: Those files are never directly built, only included in other files. Pull Request resolved: #46335 Reviewed By: albanD Differential Revision: D24316737 Pulled By: gchanan fbshipit-source-id: 67bb95e7f4450e3bbd0cd54f15fde9b6ff177479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those files are never directly built, only included in other files.