Add named tuple's error message and workaround for RET failure #46347

jwpark1985 · 2020-10-14T21:51:28Z

Stack from ghstack:

Add named tuple's error message and workaround for RET failure #46347 Add named tuple's error message and workaround for RET failure

Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile.

To identify the error cases (returning NamedTuple type), I used the following coditions:

ins.op == RET (for returing)
type->kind() == TypeKind::TupleType (for pruning non-tuple types)
type->cast().name() (for pruning Tuple type)

I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this.

[Information of Tuple and NamedTuple types]

Tuple
type->str(): (int, int)
type->repr_str(): Tuple[int, int]
type->kind(): TypeKind::TupleType # different with other types
type()->cast(): True
type()->cast()>name(): False # different with NamedTuple
NamedTuple
type->str(): torch.myNamedTuple
type->repr_str(): torch.myNamedTuple
type->kind(): TypeKind::TupleType # different with other types
type()->cast(): True
type->cast().name() = True # different with Tuple

(From the next diff, I will handle the other error cases: 1) returning List, Dict and 2) accessing Module class's member functions)

Differential Revision: D24291962

Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/) [ghstack-poisoned]

Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/) ghstack-source-id: 114324445 Pull Request resolved: #46347

dr-ci · 2020-10-14T22:09:40Z

💊 CI failures summary and remediations

As of commit 8f12b8b (more details on the Dr. CI page):

1/2 failures possibly* introduced in this PR
- 2/1 non-CircleCI failure(s)
1/2 broken upstream at merge base 635aebd from Oct 14 until Oct 15 (29 commits; dec61f9 - bd44933)

1 failure confirmed as flaky and can be ignored:

docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c

ci.pytorch.org: 2 failed

Failed: pr/caffe2-pytorch-linux-bionic-rocm3.8-py3.6-test
Failed: pr/pytorch-linux-bionic-rocm3.8-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

facebook-github-bot · 2020-10-14T22:17:46Z

💊 CI failures summary and remediations

As of commit 8f12b8b (more details on the Dr. CI page):

1/1 failures introduced in this PR---

1 failure not recognized by patterns:

Job	Step	Action
^{docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c}	^{Check if image should be built}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

…lure" Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/) [ghstack-poisoned]

Pull Request resolved: #46347 Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) ghstack-source-id: 114335601 Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/)

…lure" Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/) [ghstack-poisoned]

Pull Request resolved: #46347 Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) ghstack-source-id: 114339694 Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/)

codecov · 2020-10-15T03:07:26Z

Codecov Report

Merging #46347 into gh/jwpark1985/1/base will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           gh/jwpark1985/1/base   #46347      +/-   ##
========================================================
- Coverage                 68.33%   68.33%   -0.01%     
========================================================
  Files                       408      408              
  Lines                     53758    53758              
========================================================
- Hits                      36735    36734       -1     
- Misses                    17023    17024       +1

Impacted Files	Coverage Δ
torch/testing/_internal/expecttest.py	`77.55% <0.00%> (-1.03%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635aebd...8f12b8b. Read the comment docs.

…lure" Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/) [ghstack-poisoned]

Pull Request resolved: #46347 Added the named tuple's error messages & workarounds when it returns from a function of a class in Pytorch Mobile. To identify the error cases (returning NamedTuple type), I used the following coditions: 1) ins.op == RET (for returing) 2) type->kind() == TypeKind::TupleType (for pruning non-tuple types) 3) type->cast<TupleType>().name() (for pruning Tuple type) - I could use the type's str (str() or repr_str()) directly, but I used whether it has the "name" attribute. Please give the comment for this. [Information of Tuple and NamedTuple types] 1. Tuple type->str(): (int, int) type->repr_str(): Tuple[int, int] type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type()->cast<NamedType>()>name(): False # different with NamedTuple 2. NamedTuple type->str(): __torch__.myNamedTuple type->repr_str(): __torch__.myNamedTuple type->kind(): TypeKind::TupleType # different with other types type()->cast<NamedType>(): True type->cast<TupleType>().name() = True # different with Tuple (From the next diff, I will handle the other error cases: 1) returning List<module class>, Dict<module class> and 2) accessing Module class's member functions) ghstack-source-id: 114361762 Differential Revision: [D24291962](https://our.internmc.facebook.com/intern/diff/D24291962/)

facebook-github-bot · 2020-10-16T02:16:26Z

This pull request has been merged in 92921c8.

facebook-github-bot · 2020-10-16T02:16:33Z

This pull request has been merged in 92921c8.

jwpark1985 requested a review from apaszke as a code owner October 14, 2020 21:51

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 14, 2020

facebook-github-bot closed this in 92921c8 Oct 16, 2020

facebook-github-bot added the Merged label Oct 16, 2020

facebook-github-bot deleted the gh/jwpark1985/1/head branch October 19, 2020 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add named tuple's error message and workaround for RET failure #46347

Add named tuple's error message and workaround for RET failure #46347

jwpark1985 commented Oct 14, 2020 •

edited

dr-ci bot commented Oct 14, 2020 •

edited

facebook-github-bot commented Oct 14, 2020 •

edited

codecov bot commented Oct 15, 2020 •

edited

facebook-github-bot commented Oct 16, 2020

facebook-github-bot commented Oct 16, 2020

Add named tuple's error message and workaround for RET failure #46347

Add named tuple's error message and workaround for RET failure #46347

Conversation

jwpark1985 commented Oct 14, 2020 • edited

dr-ci bot commented Oct 14, 2020 • edited

💊 CI failures summary and remediations

ci.pytorch.org: 2 failed

facebook-github-bot commented Oct 14, 2020 • edited

💊 CI failures summary and remediations

1 failure not recognized by patterns:

codecov bot commented Oct 15, 2020 • edited

Codecov Report

facebook-github-bot commented Oct 16, 2020

facebook-github-bot commented Oct 16, 2020

jwpark1985 commented Oct 14, 2020 •

edited

dr-ci bot commented Oct 14, 2020 •

edited

facebook-github-bot commented Oct 14, 2020 •

edited

codecov bot commented Oct 15, 2020 •

edited