[JIT] Make InsertInstruction overflow check a warning instead of fatal

[gmagogsfm]

This diff restores previous behavior of silently allow overflowing when inserting instructions. The behavior was changed recently in #45382. But it started to break some existing use cases that haver overflow problems.

Restoring original behavior but throw a warning to to unblock existing use cases where overflowing happens.

Also fixes a but that incorrectly treats N in instruction as int16 while it is uint16

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit c14b0ad431 (more details on the Dr. CI page):

---

• 1/1 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)---

Extra GitHub checks: 1 failed

• Failed: GitHub Actions - clang-format

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

[dr-ci]

💊 CI failures summary and remediations

As of commit fa7b83d (more details on the Dr. CI page):

---

• 3/6 failures possibly* introduced in this PR
  • 3/3 non-CircleCI failure(s)
• 3/6 broken upstream at merge base 1f9ddf6 on Oct 12 from 10:06pm to 11:17pm PDT (1 commit; 1f9ddf6 - e6d30c8)

---

🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

• pytorch_linux_xenial_cuda10_2_cudnn7_py3_jit_legacy_test on Oct 12 from 10:06pm to 11:17pm PDT (1 commit; 1f9ddf6 - e6d30c8)
  • 🔁 rerun
• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 on Oct 12 from 10:06pm to 11:17pm PDT (1 commit; 1f9ddf6 - e6d30c8)
  • 🔁 rerun
• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 on Oct 12 from 10:06pm to 11:17pm PDT (1 commit; 1f9ddf6 - e6d30c8)
  • 🔁 rerun

---

Extra GitHub checks: 1 failed

• Failed: GitHub Actions - clang-tidy

---

ci.pytorch.org: 2 failed

• Failed: pr/caffe2-pytorch-linux-bionic-rocm3.8-py3.6-test
• Failed: pr/pytorch-linux-bionic-rocm3.8-py3.6

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

[facebook-github-bot]

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@gmagogsfm merged this pull request in 86abc8c.