[RPC] print exception message on workers that run python functions #46372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
rohan-varma
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 65dad6a (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Oct 15, 2020
Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! ghstack-source-id: 114351298 Pull Request resolved: #46372
💊 CI failures summary and remediationsAs of commit 51b50a1 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 22 times. |
|
These were caused by upstream breakages that are already fixed |
pritamdamania87
approved these changes
Oct 16, 2020
…unctions" Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
…unctions" Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
…unctions" Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
…unctions" Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Oct 21, 2020
Pull Request resolved: #46372 Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! ghstack-source-id: 114854333
…unctions" Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Oct 22, 2020
Pull Request resolved: #46372 Currently, in `_run_function`, we catch an exception from the python function which is run, and report it back to the master. However in some large scale training jobs, it would be valuable to also log the error on the trainer itself for faster debugging. Differential Revision: [D24324578](https://our.internmc.facebook.com/intern/diff/D24324578/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24324578/)! ghstack-source-id: 114897589
|
This pull request has been merged in 25dc005. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Currently, in
_run_function, we catch an exception from the pythonfunction which is run, and report it back to the master. However in some large
scale training jobs, it would be valuable to also log the error on the trainer
itself for faster debugging.
Differential Revision: D24324578
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!