Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci all/taylorrobie/timer papercuts 1.7 #46403

Closed
wants to merge 7 commits into from

Conversation

robieta
Copy link

@robieta robieta commented Oct 15, 2020

Important cleanup for benchmark utils.

@facebook-github-bot
Copy link
Contributor

💊 CI failures summary and remediations

As of commit cb88ae0 (more details on the Dr. CI page):


Commit cb88ae0 was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 times.

@dr-ci
Copy link

dr-ci bot commented Oct 15, 2020

💊 CI failures summary and remediations

As of commit 73c587d (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 20 times.

@gchanan gchanan added this to the 1.7.0 milestone Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #46403 into release/1.7 will increase coverage by 0.06%.
The diff coverage is 71.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.7   #46403      +/-   ##
===============================================
+ Coverage        68.43%   68.49%   +0.06%     
===============================================
  Files              406      406              
  Lines            52321    52452     +131     
===============================================
+ Hits             35805    35928     +123     
- Misses           16516    16524       +8     
Impacted Files Coverage Δ
...enchmark/utils/valgrind_wrapper/timer_interface.py 50.00% <60.84%> (+24.21%) ⬆️
torch/utils/benchmark/utils/timer.py 85.88% <83.33%> (+7.05%) ⬆️
torch/utils/benchmark/utils/common.py 98.63% <97.43%> (+2.23%) ⬆️
torch/utils/benchmark/__init__.py 100.00% <100.00%> (ø)
torch/utils/benchmark/utils/compare.py 97.96% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85d494...73c587d. Read the comment docs.

@seemethere seemethere removed this from the 1.7.0 milestone Oct 27, 2020
@robieta robieta closed this Dec 30, 2020
@robieta robieta deleted the ci-all/taylorrobie/timer_papercuts_1.7 branch January 11, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants