Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quant] Allow replacement of the custom modules in the "prepare" step #46426

Closed
wants to merge 2 commits into from

Conversation

z-a-f
Copy link
Contributor

@z-a-f z-a-f commented Oct 15, 2020

Stack from ghstack:

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 15, 2020

💊 CI failures summary and remediations

As of commit 05edf1d (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@dr-ci
Copy link

dr-ci bot commented Oct 15, 2020

💊 CI failures summary and remediations

As of commit 05edf1d (more details on the Dr. CI page):


  • 7/7 failures possibly* introduced in this PR
    • 1/7 non-CircleCI failure(s)

🕵️ 6 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 15 22:54:04 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n ^\n" }
Oct 15 22:54:03     raise RuntimeError(err_message) 
Oct 15 22:54:03 RuntimeError: test_quantization failed! 
Oct 15 22:54:04  
Oct 15 22:54:04 real	19m31.080s 
Oct 15 22:54:04 user	30m35.396s 
Oct 15 22:54:04 sys	3m9.059s 
Oct 15 22:54:04 + cleanup 
Oct 15 22:54:04 + retcode=1 
Oct 15 22:54:04 + set +x 
Oct 15 22:54:04 =================== sccache compilation log =================== 
Oct 15 22:54:04 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Oct 15 22:54:04  
Oct 15 22:54:04 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Oct 15 22:54:04 Compile requests                 60 
Oct 15 22:54:04 Compile requests executed        37 
Oct 15 22:54:04 Cache hits                       24 
Oct 15 22:54:04 Cache misses                     12 
Oct 15 22:54:04 Cache timeouts                    0 
Oct 15 22:54:04 Cache read errors                 0 
Oct 15 22:54:04 Forced recaches                   0 
Oct 15 22:54:04 Cache write errors                0 

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test (2/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 15 23:00:57 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function ‘int main()’:\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:22: error: expected ‘;’ before ‘}’ token\n 2 | int main() { return 0 }\n | ^~\n | ;\n" }
Oct 15 23:00:57     raise RuntimeError(err_message) 
Oct 15 23:00:57 RuntimeError: test_quantization failed! 
Oct 15 23:00:57  
Oct 15 23:00:57 real	25m6.865s 
Oct 15 23:00:57 user	29m4.493s 
Oct 15 23:00:57 sys	0m49.284s 
Oct 15 23:00:57 + cleanup 
Oct 15 23:00:57 + retcode=1 
Oct 15 23:00:57 + set +x 
Oct 15 23:00:57 =================== sccache compilation log =================== 
Oct 15 23:00:57 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function ‘int main()’:\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:22: error: expected ‘;’ before ‘}’ token\n    2 | int main() { return 0 }\n      |                      ^~\n      |                      ;\n" } 
Oct 15 23:00:57  
Oct 15 23:00:57 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Oct 15 23:00:57 Compile requests                 60 
Oct 15 23:00:57 Compile requests executed        37 
Oct 15 23:00:57 Cache hits                       24 
Oct 15 23:00:57 Cache misses                     12 
Oct 15 23:00:57 Cache timeouts                    0 
Oct 15 23:00:57 Cache read errors                 0 
Oct 15 23:00:57 Forced recaches                   0 
Oct 15 23:00:57 Cache write errors                0 

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 (3/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 15 23:55:44 ERROR [0.007s]: test_custom_module_class (quantization.test_quantize.TestPostTrainingStatic)
Oct 15 23:55:37 Tests the correctness of the layernorm module. ... ok (0.005s) 
Oct 15 23:55:37   test_leaky_relu (quantization.test_quantized_module.TestStaticQuantizedModule) ... ok (0.003s) 
Oct 15 23:55:44   test_linear_api (quantization.test_quantized_module.TestStaticQuantizedModule) ... ok (6.612s) 
Oct 15 23:55:44   test_pool_api (quantization.test_quantized_module.TestStaticQuantizedModule) 
Oct 15 23:55:44 Tests the correctness of the pool module. ... ok (0.018s) 
Oct 15 23:55:44   test_quant_dequant_api (quantization.test_quantized_module.TestStaticQuantizedModule) ... ok (0.003s) 
Oct 15 23:55:44   test_relu (quantization.test_quantized_module.TestStaticQuantizedModule) ... ok (0.003s) 
Oct 15 23:55:44   test_sigmoid (quantization.test_quantized_module.TestStaticQuantizedModule) ... ok (0.004s) 
Oct 15 23:55:44  
Oct 15 23:55:44 ====================================================================== 
Oct 15 23:55:44 ERROR [0.007s]: test_custom_module_class (quantization.test_quantize.TestPostTrainingStatic) 
Oct 15 23:55:44 ---------------------------------------------------------------------- 
Oct 15 23:55:44 Traceback (most recent call last): 
Oct 15 23:55:44   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_quantization.py", line 264, in wrapper 
Oct 15 23:55:44     fn(*args, **kwargs) 
Oct 15 23:55:44   File "/var/lib/jenkins/workspace/test/quantization/test_quantize.py", line 673, in test_custom_module_class 
Oct 15 23:55:44     m = prepare(original_m) 
Oct 15 23:55:44   File "/opt/conda/lib/python3.6/site-packages/torch/quantization/quantize.py", line 219, in prepare 
Oct 15 23:55:44     new_child = new_child.from_float(child, qconfig=qconfig) 
Oct 15 23:55:44 TypeError: from_float() got an unexpected keyword argument 'qconfig' 
Oct 15 23:55:44  

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test1 (4/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 15 22:33:24 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in
Oct 15 22:33:24     #7 0x5624c0dc070b in PyEval_EvalCode /tmp/build/80754af9/python_1599604603603/work/Python/ceval.c:731 
Oct 15 22:33:24     #8 0x5624c0e40573 in run_mod /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:1025 
Oct 15 22:33:24     #9 0x5624c0e4060c in PyRun_StringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:949 
Oct 15 22:33:24     #10 0x5624c0e4066e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:445 
Oct 15 22:33:24     #11 0x5624c0e44472 in run_command /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:301 
Oct 15 22:33:24     #12 0x5624c0e44472 in Py_Main /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:749 
Oct 15 22:33:24     #13 0x5624c0d0e43d in main /tmp/build/80754af9/python_1599604603603/work/Programs/python.c:69 
Oct 15 22:33:24     #14 0x7f4bca71883f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291 
Oct 15 22:33:24     #15 0x5624c0dedd0a in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
Oct 15 22:33:24  
Oct 15 22:33:24 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in  
Oct 15 22:33:24 + retcode=1 
Oct 15 22:33:24 + set -e 
Oct 15 22:33:24 + return 1 
Oct 15 22:33:24 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]] 
Oct 15 22:33:24 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]] 
Oct 15 22:33:24 + '[' -n https://github.com/pytorch/pytorch/pull/46426 ']' 
Oct 15 22:33:24 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]] 
Oct 15 22:33:24 ++ mktemp 
Oct 15 22:33:24 + DETERMINE_FROM=/tmp/tmp.GOc1EXPhf1 
Oct 15 22:33:24 + file_diff_from_base /tmp/tmp.GOc1EXPhf1 

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (5/6)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 15 22:59:31 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n ^\n" }
Oct 15 22:59:31 Traceback (most recent call last): 
Oct 15 22:59:31   File "test/run_test.py", line 789, in <module> 
Oct 15 22:59:31     main() 
Oct 15 22:59:31   File "test/run_test.py", line 772, in main 
Oct 15 22:59:31     raise RuntimeError(err_message) 
Oct 15 22:59:31 RuntimeError: test_quantization failed! 
Oct 15 22:59:31 + cleanup 
Oct 15 22:59:31 + retcode=1 
Oct 15 22:59:31 + set +x 
Oct 15 22:59:31 =================== sccache compilation log =================== 
Oct 15 22:59:31 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Oct 15 22:59:31  
Oct 15 22:59:31 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Oct 15 22:59:31 Compile requests                 60 
Oct 15 22:59:31 Compile requests executed        37 
Oct 15 22:59:31 Cache hits                       24 
Oct 15 22:59:31 Cache misses                     12 
Oct 15 22:59:31 Cache timeouts                    0 
Oct 15 22:59:31 Cache read errors                 0 
Oct 15 22:59:31 Forced recaches                   0 
Oct 15 22:59:31 Cache write errors                0 

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (6/6)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_quantization failed!
Generated XML report: test-reports\dist-gloo\TEST-quantization.test_workflow_module.TestRecordHistogramObserver-20201015234128.xml 
Generated XML report: test-reports\dist-gloo\TEST-quantization.test_backward_compatibility.TestSerialization-20201015234128.xml 
Generated XML report: test-reports\dist-gloo\TEST-quantization.test_quantized_module.TestStaticQuantizedModule-20201015234128.xml 
Generated XML report: test-reports\dist-gloo\TEST-quantization.test_quantized_op.TestQNNPackOps-20201015234128.xml 
Generated XML report: test-reports\dist-gloo\TEST-quantization.test_quantize_fx.TestQuantizeFxModels-20201015234128.xml 
Traceback (most recent call last): 
  File "run_test.py", line 789, in <module> 
    main() 
  File "run_test.py", line 772, in main 
    raise RuntimeError(err_message) 
RuntimeError: test_quantization failed! 
 
(base) circleci@PACKER-5F5FCBA1 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@jerryzh168
Copy link
Contributor

we are changing custom module apis, please don't touch it for the moment: #46364

@vkuzo vkuzo removed their request for review January 28, 2021 16:24
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Apr 12, 2022
@github-actions github-actions bot closed this May 12, 2022
@facebook-github-bot facebook-github-bot deleted the gh/z-a-f/76/head branch June 12, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants