Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Add metal to DispatchKeySet #46455

Closed
wants to merge 2 commits into from
Closed

Conversation

xta0
Copy link
Contributor

@xta0 xta0 commented Oct 16, 2020

Stack from ghstack:

After this PR(#46236 ) landed, the aten::copy_ can no longer be dispatched to Metal kernels.

Differential Revision: D24356769

After this PR(#46236 ) landed, the `aten::copy_` can no longer be dispatched to Metal kernels.

Differential Revision: [D24356769](https://our.internmc.facebook.com/intern/diff/D24356769/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 16, 2020

💊 CI failures summary and remediations

As of commit e40e4c8 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)---

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@dr-ci
Copy link

dr-ci bot commented Oct 16, 2020

💊 CI failures summary and remediations

As of commit ead5860 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR---

2 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_clang7_onnx_ort_test2 Run tests 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang7_onnx_ort_test1 Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #46455 into gh/xta0/57/base will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           gh/xta0/57/base   #46455      +/-   ##
===================================================
- Coverage            68.38%   68.38%   -0.01%     
===================================================
  Files                  411      411              
  Lines                53953    53953              
===================================================
- Hits                 36897    36896       -1     
- Misses               17056    17057       +1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5f81f...ead5860. Read the comment docs.

After this PR(#46236 ) landed, the `aten::copy_` can no longer be dispatched to Metal kernels.

Differential Revision: [D24356769](https://our.internmc.facebook.com/intern/diff/D24356769/)

[ghstack-poisoned]
@xta0 xta0 requested a review from ailzhang October 16, 2020 19:17
@xta0 xta0 changed the title [GPU] Add metal to code gen [GPU] Add metal to DispatchKeySet Oct 16, 2020
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5da4a08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants