Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libkineto in profiler #46470
Use libkineto in profiler #46470
Changes from 4 commits
a4d4124
e27f74c
5c3833e
662431b
ea956aa
7dfdbc9
6725778
e9a219b
49a9fee
8edb346
f288623
979cdfa
c8cbeb0
226089c
266b75f
6958eac
97e5070
8d111d2
bfb0360
1ff1a12
b3b69d8
2faeb8a
67c890d
ed8babe
ffc11fd
fe76b84
76ee80c
5761ea2
dde5ec3
3a25bd2
6023998
0bc66a6
aa2d09e
91718ac
1556a7c
4a0fec9
bb6396a
60b5dee
e1a5480
38a37dd
c6c6039
17767d1
3537e9d
043dcd2
aa17339
9262f92
8371b33
67d4acb
9f1d24f
e864205
380b874
165bb7c
445b8c1
7c317f5
c904443
1f600f8
5aacc1c
651f556
9997011
cfd0424
30114d8
27e4e9c
bde96f6
b1a0292
b7fda07
459df8e
09a4762
cafee0f
39ff2b3
5502837
7c2017b
525e5b5
1f50e4b
f70a95c
5fed8be
2494879
4f401ff
c689e6b
4a5632f
6d0e7ab
95b686f
d98a5fb
cb7367e
5ad0a34
d6bd96e
0c4faaa
ab754e1
aee38e8
671785f
8fde042
ca6cb73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you technically don't need a field on
self
- you can just checkself.kineto_activities
being non-empty belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - it could be a set from the very beginning (and use
.add()
then)