Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type check for torch.quantization.stubs #46475

Closed
wants to merge 2 commits into from

Conversation

walterddr
Copy link
Contributor

Fixes #42973

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 16, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 16, 2020

💊 CI failures summary and remediations

As of commit 0f4ed2b (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #46475 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #46475   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files         411      411           
  Lines       53953    53958    +5     
=======================================
+ Hits        36896    36901    +5     
  Misses      17057    17057           
Impacted Files Coverage Δ
torch/jit/_recursive.py 95.14% <100.00%> (+0.02%) ⬆️
torch/quantization/stubs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1745c3...0f4ed2b. Read the comment docs.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@walterddr walterddr requested a review from a team October 16, 2020 20:55
@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in 89108ba.

@facebook-github-bot facebook-github-bot deleted the gh/walterddr/typecheck_8 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable torch.quantization.stubs typechecks during CI
3 participants