Provide CMake option to enable Vulkan API. #46503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 16, 2020
Closed
Closed
💊 CI failures summary and remediationsAs of commit 416b39d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 times. |
💊 CI failures summary and remediationsAs of commit d6a2cff (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 45 times. |
added 9 commits
October 16, 2020 20:49
[ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
added 2 commits
October 19, 2020 22:39
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
AshkanAliabadi
commented
Oct 20, 2020
aten/src/ATen/CMakeLists.txt
Outdated
| @@ -65,7 +65,7 @@ file(GLOB native_cpp "native/*.cpp") | |||
| file(GLOB native_mkl_cpp "native/mkl/*.cpp") | |||
| file(GLOB native_mkldnn_cpp "native/mkldnn/*.cpp") | |||
| file(GLOB vulkan_cpp "vulkan/*.cpp") | |||
| file(GLOB native_vulkan_cpp "native/vulkan/api/*.cpp" "native/vulkan/*.cpp") | |||
| file(GLOB native_vulkan_cpp "native/vulkan/api/*.cpp" "native/vulkan/ops/*.cpp" "native/vulkan/*.cpp") | |||
There was a problem hiding this comment.
I need to fix build issues you encountered on the devserver as part of enabling this.
IvanKobzarev
approved these changes
Oct 20, 2020
added 3 commits
October 20, 2020 10:03
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
Differential Revision: [D24379144](https://our.internmc.facebook.com/intern/diff/D24379144) [ghstack-poisoned]
|
@AshkanAliabadi merged this pull request in 6cd8b5e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D24379144