-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradient Compression] Refactor CommHookInterface and PythonCommHook. #46512
Commits on Oct 17, 2020
-
[Gradient Compression] Refactor CommHookInterface and PythonCommHook.
1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations. 2. Merge 1-line PythonCommHook constructor into the header for simplicity. 3. Rename processFuture method as parseFromHookResult for readability. 4. Simplify the comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 17, 2020 Configuration menu - View commit details
-
Copy full SHA for b284620 - Browse repository at this point
Copy the full SHA b284620View commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations. 2. Merge 1-line PythonCommHook constructor into the header for simplicity. 3. Rename processFuture method as parseFromHookResult for readability. 4. Simplify the comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 17, 2020 Configuration menu - View commit details
-
Copy full SHA for d01a4d5 - Browse repository at this point
Copy the full SHA d01a4d5View commit details
Commits on Oct 22, 2020
-
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations. 2. Merge 1-line PythonCommHook constructor into the header for simplicity. 3. Rename processFuture method as parseFromHookResult for readability. 4. Simplify the comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 22, 2020 Configuration menu - View commit details
-
Copy full SHA for 6e98cd3 - Browse repository at this point
Copy the full SHA 6e98cd3View commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Move the implementation of PythonCommHook destructor from the header file to the cpp file. 3. Rename processFuture method as parseHookResult for readability. 4. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 22, 2020 Configuration menu - View commit details
-
Copy full SHA for 77bc093 - Browse repository at this point
Copy the full SHA 77bc093View commit details
Commits on Oct 23, 2020
-
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Move the implementation of PythonCommHook destructor from the header file to the cpp file. 3. Rename processFuture method as parseHookResult for readability. 4. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 8aa1ab1 - Browse repository at this point
Copy the full SHA 8aa1ab1View commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Move the implementation of PythonCommHook destructor from the header file to the cpp file. 3. Rename processFuture method as parseHookResult for readability. 4. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for ec6ea25 - Browse repository at this point
Copy the full SHA ec6ea25View commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Rename processFuture method as parseHookResult for readability. 3. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for ae455eb - Browse repository at this point
Copy the full SHA ae455ebView commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Rename processFuture method as parseHookResult for readability. 3. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 0137f5b - Browse repository at this point
Copy the full SHA 0137f5bView commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Rename processFuture method as parseHookResult for readability. 3. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 061e0b2 - Browse repository at this point
Copy the full SHA 061e0b2View commit details -
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Rename processFuture method as parseHookResult for readability. 3. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 0d1f6f2 - Browse repository at this point
Copy the full SHA 0d1f6f2View commit details
Commits on Oct 24, 2020
-
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Rename processFuture method as parseHookResult for readability. 3. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 24, 2020 Configuration menu - View commit details
-
Copy full SHA for e3ff2a5 - Browse repository at this point
Copy the full SHA e3ff2a5View commit details
Commits on Oct 26, 2020
-
Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…
…onCommHook." 1. Merge 1-line PythonCommHook constructor into the header for simplicity. 2. Move the implementation of PythonCommHook destructor from the header file to cpp file. 3. Rename processFuture method as parseHookResult for readability. 4. Simplify some comments. Original PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/) [ghstack-poisoned]
wayi committedOct 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 377c729 - Browse repository at this point
Copy the full SHA 377c729View commit details