Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradient Compression] Refactor CommHookInterface and PythonCommHook. #46512

Closed
wants to merge 12 commits into from

Commits on Oct 17, 2020

  1. [Gradient Compression] Refactor CommHookInterface and PythonCommHook.

    1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations.
    2. Merge 1-line PythonCommHook constructor into the header for simplicity.
    3. Rename processFuture method as parseFromHookResult for readability.
    4. Simplify the comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    b284620 View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations.
    2. Merge 1-line PythonCommHook constructor into the header for simplicity.
    3. Rename processFuture method as parseFromHookResult for readability.
    4. Simplify the comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    d01a4d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations.
    2. Merge 1-line PythonCommHook constructor into the header for simplicity.
    3. Rename processFuture method as parseFromHookResult for readability.
    4. Simplify the comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6e98cd3 View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Move the implementation of PythonCommHook destructor from the header file to the cpp file.
    3. Rename processFuture method as parseHookResult for readability.
    4. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    77bc093 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Move the implementation of PythonCommHook destructor from the header file to the cpp file.
    3. Rename processFuture method as parseHookResult for readability.
    4. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    8aa1ab1 View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Move the implementation of PythonCommHook destructor from the header file to the cpp file.
    3. Rename processFuture method as parseHookResult for readability.
    4. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ec6ea25 View commit details
    Browse the repository at this point in the history
  3. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Rename processFuture method as parseHookResult for readability.
    3. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ae455eb View commit details
    Browse the repository at this point in the history
  4. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Rename processFuture method as parseHookResult for readability.
    3. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0137f5b View commit details
    Browse the repository at this point in the history
  5. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Rename processFuture method as parseHookResult for readability.
    3. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    061e0b2 View commit details
    Browse the repository at this point in the history
  6. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Rename processFuture method as parseHookResult for readability.
    3. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0d1f6f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Rename processFuture method as parseHookResult for readability.
    3. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    e3ff2a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Update on "[Gradient Compression] Refactor CommHookInterface and Pyth…

    …onCommHook."
    
    
    1. Merge 1-line PythonCommHook constructor into the header for simplicity.
    2. Move the implementation of PythonCommHook destructor from the header file to cpp file.
    3. Rename processFuture method as parseHookResult for readability.
    4. Simplify some comments.
    
    Original PR issue: C++ DDP Communication Hook #46348
    
    Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
    
    [ghstack-poisoned]
    wayi committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    377c729 View commit details
    Browse the repository at this point in the history