Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Handle sequence output shape and type inference #46542

Closed
wants to merge 233 commits into from
Closed

[ONNX] Handle sequence output shape and type inference #46542

wants to merge 233 commits into from

Conversation

neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Oct 19, 2020 •
edited

Handle sequence output shape and type inference.

This PR fixes value type of sequence outputs. Prior to this, all model sequence type outputs were unfolded for ONNX models.
This PR also enable shape inference for sequence outputs to represent the dynamic shape of these values.

@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
0d70fdc 
…oof/functionalization

# Conflicts:
#	aten/src/ATen/core/ivalue.h
#	aten/src/ATen/core/ivalue_inl.h
#	aten/src/ATen/native/TestOps.cpp
#	aten/src/ATen/native/native_functions.yaml
#	test/test_native_functions.py
#	tools/autograd/gen_autograd_functions.py
#	tools/jit/gen_unboxing_wrappers.py
#	torch/csrc/utils/python_arg_parser.h
@neginraoof
use lower_graph_pass for training mode
8be085d
@neginraoof
Enable model tests
9fb8c13
@neginraoof
Enable scripting tests for models
644608a
@neginraoof
update utils
1bc8553
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
b6d4866 
…oof/functionalization
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
3db513c 
…oof/functionalization
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
14b9f0e 
…oof/functionalization
@neginraoof
refactor code branch
e2eddc5
@neginraoof
Rename
4954f00
@neginraoof
Added comments
b90f9f6
@neginraoof
Added comments
241e32d
@neginraoof
refactor back
7c524c7
@neginraoof
remove propagate
ea18bd2
@neginraoof
Enable script tests by default
3e646c3
@neginraoof
Merge branch 'master' into neraoof/functionalization
0cd383c
@neginraoof
Update test_models.py
0e7895a
@neginraoof
Update utils.py
b97d573
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
b51b3d3 
…oof/functionalization
@neginraoof
Fix jit
e793ffd
@neginraoof
Merge branch 'master' into neraoof/functionalization
283c826
@neginraoof
Update utils.py
41994ea
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
9033802 
…oof/functionalization
@neginraoof
Merge branch 'neraoof/functionalization' of github.com:neginraoof/pyt…
91d7842 
…orch into neraoof/functionalization
@neginraoof
skip embedding_bag scripting tests
fe023c3
@neginraoof
Fix for feedback on example_output
04587b4
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
0fd6920 
…oof/functionalization
@neginraoof
update _retain_param_name name
64727f1
@neginraoof
Update utils.py
4f15616
@neginraoof
Adding jit remote_mutation pass
4207ef6
@neginraoof
Copy link
Contributor Author

@bzinodev
Would you please help us merge this PR? This one is the last PR we would like you to merge to master, and it is a high priority PR.

Thanks a lot.

bzinodev
bzinodev suggested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@bzinodev bzinodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change to ONNX export API as know it can return lists.

We need more description of this change and discuss if we are break backward compatibility

facebook-github-bot
facebook-github-bot reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jan 10, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

@bzinodev
Is it okay to merge this PR now?

@neginraoof
Merge commit 'refs/pull/50150/head' of https://github.com/pytorch/pyt…
0e80469 
…orch into neraoof/opset13

# Conflicts:
#	test/onnx/test_pytorch_onnx_onnxruntime.py
@neginraoof
merge
fba9bea
facebook-github-bot
facebook-github-bot reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in adc65e7.

@neginraoof
Copy link
Contributor Author

PR to fix broken mypy tests: #50571

@nairbv
Copy link
Collaborator

nairbv commented Jan 15, 2021

Hi @neginraoof, there's an "unland" for this diff that's already in progress (we actively revert changes when tests fail). Can you re-submit the original diff including the fix from 50571 (once the reverting change finishes landing)?

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by a9db2f8.

@neginraoof neginraoof mentioned this pull request Jan 15, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Jan 21, 2021
@neginraoof @facebook-github-bot
[ONNX] Handle sequence output for models (#50599)
137f2a3 
Summary:
Duplicate of #46542

Pull Request resolved: #50599

Reviewed By: SplitInfinity

Differential Revision: D25928897

Pulled By: bzinodev

fbshipit-source-id: a898cef7b2d15a287aedd9798ce1423cebf378d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@bzinodev bzinodev bzinodev approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@neginraoof @facebook-github-bot @BowenBao @nairbv @bzinodev @ezyang @pytorchbot