Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for source code comments at any level of indentation #46548

Closed
wants to merge 2 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Oct 19, 2020

Stack from ghstack:

Differential Revision: D24434778

@ansley ansley requested a review from apaszke as a code owner October 19, 2020 19:09
ansley pushed a commit that referenced this pull request Oct 19, 2020
ghstack-source-id: f33bd4884c7c613e71cca6b1ad58f26eee811059
Pull Request resolved: #46548
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 19, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 19, 2020

💊 CI failures summary and remediations

As of commit bbb1796 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@ansley ansley linked an issue Oct 19, 2020 that may be closed by this pull request
@ansley ansley requested a review from jamesr66a October 19, 2020 19:10
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #46548 into gh/ansleyadelaide/12/base will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                      Coverage Diff                      @@
##           gh/ansleyadelaide/12/base   #46548      +/-   ##
=============================================================
- Coverage                      68.39%   68.39%   -0.01%     
=============================================================
  Files                            411      411              
  Lines                          53975    53974       -1     
=============================================================
- Hits                           36916    36915       -1     
  Misses                         17059    17059              

Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please import and wait for internal tests to pass

torch/jit/frontend.py Outdated Show resolved Hide resolved
torch/jit/frontend.py Outdated Show resolved Hide resolved
ansley pushed a commit that referenced this pull request Oct 20, 2020
ghstack-source-id: 8befb6ca8f87323af9d796af4344100638055df6
Pull Request resolved: #46548
@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in 475b4e3.

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/12/head branch October 25, 2020 14:18
@ppwwyyxx
Copy link
Contributor

normalize_source_lines is not robust: given a function like https://github.com/google/jax/blob/32564442cbab5bec712cadc316a1c01396faf89c/jax/_src/numpy/linalg.py#L296, part of the decorator code also starts with "def", so normalize_source_lines will not correctly find the real definition line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JIT] Source code dedent doesn't ignore comments like Python
4 participants