[Gradient Compression] Add CppCommHook subclass for supporting the C++ API of communication hook. #46566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ API of communication hook. Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
wayi1
requested review from
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 45084ff (more details on the Dr. CI page): Commit 45084ff was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
facebook-github-bot
added
the
oncall: distributed
💊 CI failures summary and remediationsAs of commit c78c03a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 46 times. |
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Oct 19, 2020
…+ API of communication hook. Pull Request resolved: #46566 Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 ghstack-source-id: 114668384 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/)
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Oct 20, 2020
…+ API of communication hook. Pull Request resolved: #46566 Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 ghstack-source-id: 114687935 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/)
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Oct 27, 2020
…+ API of communication hook. Pull Request resolved: #46566 Only provides an interface. Some built-in implementations will be provided in a follow-up commit. Original PR issue: C++ DDP Communication Hook #46348 ghstack-source-id: 115213919 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/)
pritamdamania87
approved these changes
Oct 27, 2020
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
…ting the C++ API of communication hook." Only provides an interface. Some built-in implementations will be provided in a follow-up commit. riginal PR issue: C++ DDP Communication Hook #46348 Differential Revision: [D24379460](https://our.internmc.facebook.com/intern/diff/D24379460/) [ghstack-poisoned]
|
This pull request has been merged in e077a2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Only provides an interface. Some built-in implementations will be provided in a follow-up commit.
riginal PR issue: C++ DDP Communication Hook #46348
Differential Revision: D24379460