[py][vulkan][reland] Add is_vulkan to py api, add vulkan to device type parsing #46655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe parsing Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev [ghstack-poisoned]
IvanKobzarev
requested review from
albanD,
apaszke,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
IvanKobzarev
added a commit
that referenced
this pull request
Oct 21, 2020
…pe parsing Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev ghstack-source-id: 172784fa8ec49eac815eed60e1a7de49d92e8040 Pull Request resolved: #46655
facebook-github-bot
added
oncall: jit
…o device type parsing" Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev Differential Revision: [D24448984](https://our.internmc.facebook.com/intern/diff/D24448984) Reland of the PR: #46511 The initial PR broke tests as they assert the error message that was changed in PR torch/testing/_internal/distributed/nn/api/remote_module_test.py In this PR it is changed accordingly [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 01f367f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
…o device type parsing" Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev Differential Revision: [D24448984](https://our.internmc.facebook.com/intern/diff/D24448984) Reland of the PR: #46511 The initial PR broke tests as they assert the error message that was changed in PR torch/testing/_internal/distributed/nn/api/remote_module_test.py In this PR it is changed accordingly [ghstack-poisoned]
IvanKobzarev
added a commit
that referenced
this pull request
Oct 22, 2020
…pe parsing Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev ghstack-source-id: 6bda8848865704a7850e8c81e5f4aea41269f135 Pull Request resolved: #46655
…o device type parsing" Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev Differential Revision: [D24448984](https://our.internmc.facebook.com/intern/diff/D24448984) Reland of the PR: #46511 The initial PR broke tests as they assert the error message that was changed in PR torch/testing/_internal/distributed/nn/api/remote_module_test.py In this PR it is changed accordingly [ghstack-poisoned]
IvanKobzarev
added a commit
that referenced
this pull request
Oct 22, 2020
…pe parsing Summary: Test Plan: Imported from OSS Pulled By: IvanKobzarev ghstack-source-id: c7a6bea3d4b5939391ddc2329ecb9ef6368197d0 Pull Request resolved: #46655
|
@IvanKobzarev merged this pull request in 3112e23. |
1 similar comment
|
@IvanKobzarev merged this pull request in 3112e23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan: Imported from OSS
Pulled By: IvanKobzarev
Differential Revision: D24448984
Reland of the PR: #46511
The initial PR broke tests as they assert the error message that was changed in PR
torch/testing/_internal/distributed/nn/api/remote_module_test.py
In this PR it is changed accordingly