Make add_relu an internal function #46676

albanD · 2020-10-21T20:49:19Z

Cleanup for 1.7

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

aten/src/ATen/native/native_functions.yaml

gchanan

this will require the BC allow list.

dr-ci · 2020-10-21T22:08:37Z

💊 CI failures summary and remediations

As of commit 349a39c (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_rocm3_7_py3_6_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Oct 22 14:37:15 caused by: Connection refused (os error 111)

Oct 22 14:37:15 ++++ extract_trap_cmd 
Oct 22 14:37:15 ++++ printf '%s\n' '' 
Oct 22 14:37:15 +++ printf '%s\n' cleanup 
Oct 22 14:37:15 ++ trap -- ' 
Oct 22 14:37:15 cleanup' EXIT 
Oct 22 14:37:15 ++ [[ pytorch-linux-bionic-rocm3.7-py3.6-build != *pytorch-win-* ]] 
Oct 22 14:37:15 ++ which sccache 
Oct 22 14:37:15 ++ sccache --stop-server 
Oct 22 14:37:15 Stopping sccache server... 
Oct 22 14:37:15 error: couldn't connect to server 
Oct 22 14:37:15 caused by: Connection refused (os error 111) 
Oct 22 14:37:15 ++ true 
Oct 22 14:37:15 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 22 14:37:15 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 22 14:37:15 ++ true 
Oct 22 14:37:15 ++ [[ pytorch-linux-bionic-rocm3.7-py3.6-build == *rocm* ]] 
Oct 22 14:37:15 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 22 14:37:15 ++ SCCACHE_IDLE_TIMEOUT=0 
Oct 22 14:37:15 ++ sccache --start-server 
Oct 22 14:37:15 Starting sccache server... 
Oct 22 14:37:15 ++ sccache --zero-stats

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

gchanan

are you missing changes in:
./test/test_mobile_optimizer.py ?
./tools/code_analyzer/default_op_deps.yaml ?

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

albanD · 2020-10-22T01:32:21Z

Note that the remaining backward compat failures are due to upstream failure.

gchanan · 2020-10-22T14:08:10Z

test/backward_compatibility/check_backward_compatibility.py

@@ -128,6 +128,8 @@
    ("aten::_foreach_addcdiv_", datetime.date(2020, 10, 15)),
    ("aten::_foreach_addcdiv", datetime.date(2020, 10, 15)),
    ("aten::_foreach_addcmul", datetime.date(2020, 10, 15)),
+    ("aten::add_relu", datetime.date(2020, 10, 28)),


when you do the cherry pick can you change this to ", datetime.date(2020, 12, 1)), -- that's just an arbitrary date in the future past the expected release date that we've been using.

aten/src/ATen/native/native_functions.yaml

albanD · 2020-10-22T14:22:54Z

TODO for follow up:

Rename all the internal functions as internal with _*
Consider moving to "python_module: nn" as it is nn specific

facebook-github-bot

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-10-23T02:20:43Z

@albanD merged this pull request in 27e2ea4.

Summary: Cleanup for 1.7 Pull Request resolved: pytorch#46676 Reviewed By: gchanan Differential Revision: D24458565 Pulled By: albanD fbshipit-source-id: b1e4b4630233d3f1a4bac20e3077411d1ae17f7b # Conflicts: # test/backward_compatibility/check_backward_compatibility.py

Summary: Cleanup for 1.7 Pull Request resolved: #46676 Reviewed By: gchanan Differential Revision: D24458565 Pulled By: albanD fbshipit-source-id: b1e4b4630233d3f1a4bac20e3077411d1ae17f7b # Conflicts: # test/backward_compatibility/check_backward_compatibility.py

facebook-github-bot reviewed Oct 21, 2020

View reviewed changes

gchanan reviewed Oct 21, 2020

View reviewed changes

aten/src/ATen/native/native_functions.yaml Show resolved Hide resolved

gchanan reviewed Oct 21, 2020

View reviewed changes

albanD requested a review from apaszke as a code owner October 21, 2020 22:24

facebook-github-bot reviewed Oct 21, 2020

View reviewed changes

gchanan reviewed Oct 21, 2020

View reviewed changes

facebook-github-bot reviewed Oct 22, 2020

View reviewed changes

gchanan reviewed Oct 22, 2020

View reviewed changes

aten/src/ATen/native/native_functions.yaml Show resolved Hide resolved

gchanan approved these changes Oct 22, 2020

View reviewed changes

albanD added 5 commits October 22, 2020 10:25

Make add_relu an internal function

204bd89

fix test

02fdc88

fix registration

ce1de51

fix bc compat and refs

05f83a0

fix back compat

349a39c

albanD force-pushed the add_relu_cleanup branch from 2a37726 to 349a39c Compare October 22, 2020 14:27

facebook-github-bot reviewed Oct 22, 2020

View reviewed changes

facebook-github-bot closed this in 27e2ea4 Oct 23, 2020

facebook-github-bot added the Merged label Oct 23, 2020

This was referenced Oct 23, 2020

Make add_relu an internal function #46765

Merged

[v1.7.0] Release Tracker #45592

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make add_relu an internal function #46676

Make add_relu an internal function #46676

albanD commented Oct 21, 2020

facebook-github-bot left a comment

gchanan left a comment

dr-ci bot commented Oct 21, 2020 •

edited

facebook-github-bot left a comment

facebook-github-bot left a comment

gchanan left a comment

facebook-github-bot left a comment

facebook-github-bot left a comment

albanD commented Oct 22, 2020

gchanan Oct 22, 2020

albanD Oct 22, 2020

albanD commented Oct 22, 2020

facebook-github-bot left a comment

facebook-github-bot commented Oct 23, 2020

Make add_relu an internal function #46676

Make add_relu an internal function #46676

Conversation

albanD commented Oct 21, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

gchanan left a comment

Choose a reason for hiding this comment

dr-ci bot commented Oct 21, 2020 • edited

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_bionic_rocm3_7_py3_6_build (1/1)

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

gchanan left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

albanD commented Oct 22, 2020

gchanan Oct 22, 2020

Choose a reason for hiding this comment

albanD Oct 22, 2020

Choose a reason for hiding this comment

albanD commented Oct 22, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Oct 23, 2020

dr-ci bot commented Oct 21, 2020 •

edited