Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[numpy] torch.cos, torch.tan : promote integer inputs to float #46706

Closed
wants to merge 7 commits into from
Closed

[numpy] torch.cos, torch.tan : promote integer inputs to float #46706

wants to merge 7 commits into from

Conversation

kshitij12345
Copy link
Collaborator

References #42515

cc: @mruberry

@kshitij12345 kshitij12345 mentioned this pull request Oct 22, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Oct 22, 2020 •
edited

💊 CI failures summary and remediations

As of commit 11309b2 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 17 times.

@kshitij12345
remove cos from unary_op_out_casting
2fa6235 
This behavior is already tested in test_out_arg_all_dtypes
in test_unary_ufuncs.py
@kshitij12345
update cos unaryop test to verify bfloat16
89eaf29
@gchanan gchanan requested a review from mruberry October 22, 2020 17:54
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 22, 2020
mruberry
mruberry approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @kshitij12345!

facebook-github-bot
facebook-github-bot reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kshitij12345 kshitij12345 mentioned this pull request Oct 28, 2020
Closed
8 tasks
facebook-github-bot
facebook-github-bot reviewed Oct 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 5c8aad1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

Assignees
No one assigned
Labels
Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kshitij12345 @facebook-github-bot @mruberry @gchanan @pytorchbot