[RPC Framework] Support remote device format "<workername>/<device>" #46773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/) [ghstack-poisoned]
wayi1
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
wayi1
pushed a commit
that referenced
this pull request
Oct 23, 2020
Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/) ghstack-source-id: 115042926 Pull Request resolved: #46773
wayi1
changed the title
Codecov Report
@@ Coverage Diff @@
## gh/SciPioneer/18/base #46773 +/- ##
=========================================================
- Coverage 68.44% 68.43% -0.01%
=========================================================
Files 413 413
Lines 54366 54368 +2
=========================================================
- Hits 37210 37209 -1
- Misses 17156 17159 +3 |
💊 CI failures summary and remediationsAs of commit 3a89ecc (more details on the Dr. CI page):
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
|
Would be nice to mention the original issue in the PR summary: #46554 |
…/<device>"" Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Oct 28, 2020
Pull Request resolved: #46773 Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. ghstack-source-id: 115340442 Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/)
pritamdamania87
approved these changes
Oct 29, 2020
…/<device>"" Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Oct 29, 2020
Pull Request resolved: #46773 Changed the constructor of RemoteModule to accept a `remote_device` arg in the following format: "<workername>/<device>" (e.g., "trainer0/cpu", "ps0/cuda:0") This arg merges the original `on` and `device` arg. Original PR issue: RemoteDevice Format #46554 ghstack-source-id: 115448051 Differential Revision: [D24482562](https://our.internmc.facebook.com/intern/diff/D24482562/)
Thanks for the reminder! |
|
This pull request has been merged in cab32d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Changed the constructor of RemoteModule to accept a
remote_devicearg in the following format:"/" (e.g., "trainer0/cpu", "ps0/cuda:0")
This arg merges the original
onanddevicearg.Original PR issue: RemoteDevice Format #46554
Differential Revision: D24482562