[quant][graphmode][fx] custom_module support static/dynamic/weight_only quant #46786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly quant Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 23, 2020
…ly quant Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 05da8385c0669ccbaff62915881b18dd7f52768b Pull Request resolved: #46786
💊 CI failures summary and remediationsAs of commit 6eeb8d7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
| return quantized | ||
|
|
||
| class DynamicallyQuantizedCustomModule(torch.nn.Module): | ||
| def __init__(self, conv): | ||
| class DynamicQuantCustomModule(torch.nn.Module): |
There was a problem hiding this comment.
Should we have a base class that all DynamicQuantizedCustomModules should inherit from?
There was a problem hiding this comment.
why do we need this? to enforce the interface? this might be an improvement in the future if needed i think.
There was a problem hiding this comment.
Yes, this is primarily to enforce the interface so that these type of modules have the required from_observed method
There was a problem hiding this comment.
sure, we can do this in a separate PR
…c/weight_only quant" Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24514701](https://our.internmc.facebook.com/intern/diff/D24514701) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 26, 2020
…ly quant Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3b5e3a1a2bc03f768dcae0867956e14491fcab76 Pull Request resolved: #46786
raghuramank100
approved these changes
Oct 27, 2020
…c/weight_only quant" Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24514701](https://our.internmc.facebook.com/intern/diff/D24514701) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 27, 2020
…ly quant Summary: Previously we only support static quant, this PR added support for other types of quantization. Note qat is actually orthogonal to these quant types, this is referring to the convert step where we convert the observed module to a quantized module. for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 849441a7a8eec52c6510889df3bc1f8597a84546 Pull Request resolved: #46786
|
This pull request has been merged in 998b9b9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously we only support static quant, this PR added support for other types of quantization.
Note qat is actually orthogonal to these quant types, this is referring to the convert step where we
convert the observed module to a quantized module.
for qat, user will provide a CustomModule -> FakeQuantizedCustomModule in prepare_custom_config_dict
and FakeQuantizedCustomModule -> static/dynamic/weight_only quantized CustomModule in convert_custom_config_dict.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24514701