[pytorch/cuda] Concat fast path w/ zero tensor #46805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D24524441 |
💊 CI failures summary and remediationsAs of commit 6656908 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
|
This pull request was exported from Phabricator. Differential Revision: D24524441 |
xw285cornell
force-pushed
the
export-D24524441
branch
from
bdfd149
to
6cf1b1a
Compare
Summary: Pull Request resolved: pytorch#46805 The current implementation goes with slow path if there is zero tensor in the list. This is inefficient. Use the fast path for torch.cat even if there are empty tensors. This wastes one thread block for the empty tensor, but still much better than the slow path. Test Plan: CI + sandcastle Differential Revision: D24524441 fbshipit-source-id: 522dea42628207bd77a8dfba39476b1dc3c1de45
xw285cornell
force-pushed
the
export-D24524441
branch
from
6cf1b1a
to
5eac620
Compare
|
This pull request was exported from Phabricator. Differential Revision: D24524441 |
xw285cornell
force-pushed
the
export-D24524441
branch
from
5eac620
to
6656908
Compare
|
This pull request was exported from Phabricator. Differential Revision: D24524441 |
xw285cornell
changed the title
|
This pull request has been merged in e3b55a8. |
1 similar comment
|
This pull request has been merged in e3b55a8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current implementation goes with slow path if there is zero tensor in the list. This is inefficient. Use the fast path for torch.cat even if there are empty tensors. This wastes one thread block for the empty tensor, but still much better than the slow path.
Test Plan: CI + sandcastle
Differential Revision: D24524441