New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove save_state_warning in LambdaLR #46813
Conversation
💊 CI failures summary and remediationsAs of commit 7374a75 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (1/3)Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)
|
Hi @jsrozner! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
As mentioned in comment, the docstring will automatically regenerate the doc on master. :)
Since this is just updating the warning and the documentation, there is no need update the typing. |
Yes, agreed. But I was curious how the pytorch library handles typing since it is not inlined in, e.g., these function definitions Is anything else needed by me to finish this pull request? |
We are migrating to inline, but the types are in *.pyi files adjacent :)
Thanks for signing and writing the pull request, this is good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@vincentqb |
@vincentqb merged this pull request in 42e6951. |
That broke transformers where it's used: But reading why it was done (goodness), Not sure how one could deprecate a constant... |
FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: #8232 @sgugger
* [training] SAVE_STATE_WARNING was removed in pytorch FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: #8232 @sgugger * style, but add () to prevent autoformatters from botching it * switch to try/except * cleanup
* [training] SAVE_STATE_WARNING was removed in pytorch FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: huggingface#8232 @sgugger * style, but add () to prevent autoformatters from botching it * switch to try/except * cleanup
* [training] SAVE_STATE_WARNING was removed in pytorch FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: huggingface#8232 @sgugger * style, but add () to prevent autoformatters from botching it * switch to try/except * cleanup
* [training] SAVE_STATE_WARNING was removed in pytorch FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: huggingface#8232 @sgugger * style, but add () to prevent autoformatters from botching it * switch to try/except * cleanup
Fixes #46405, #43352
I updated the docstring in the local file (function level comments). Do I also need to edit somewhere else or recompile docstrings?
Also, though I didn't change any types here, how is typing (for IDE type checking) documentation generated / used)?