Fix bit math #46837
Closed
Fix bit math #46837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Formerly `static_cast<StreamId>(bits)` and `static_cast<DeviceIndex>(bits)` were and-ed against `ull` types resulting in an integer promotion which later raised a warning in downcasting passes to `Stream` and `Device`. Moving the `&` operation inside the cast results in two `uint64_t` being operated on and then cast to the correct type, eliminating the warning. Test Plan: Standard pre-commit test rig. Differential Revision: D24481292 fbshipit-source-id: 16ba68690e58ce8b710bb082542c1a5451548742
|
This pull request was exported from Phabricator. Differential Revision: D24481292 |
💊 CI failures summary and remediationsAs of commit 02b1b02 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
|
This pull request has been merged in c3fc17b. |
1 similar comment
|
This pull request has been merged in c3fc17b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Formerly
static_cast<StreamId>(bits)andstatic_cast<DeviceIndex>(bits)were and-ed againstulltypes resulting in an integer promotion which later raised a warning in downcasting passes toStreamandDevice.Moving the
&operation inside the cast results in twouint64_tbeing operated on and then cast to the correct type, eliminating the warning.Test Plan: Standard pre-commit test rig.
Differential Revision: D24481292