Fix interval midpoint calculation in vulkan #46839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Interval midpoint calculations can overflow (integers). This fixes such an instance. Test Plan: Standard test rig. Differential Revision: D24392545 fbshipit-source-id: aed0f5c2655d23fb41681f7928c23a591c344459
|
This pull request was exported from Phabricator. Differential Revision: D24392545 |
Codecov Report
@@ Coverage Diff @@
## master #46839 +/- ##
==========================================
- Coverage 68.96% 68.96% -0.01%
==========================================
Files 434 434
Lines 55996 55996
==========================================
- Hits 38620 38619 -1
- Misses 17376 17377 +1 |
|
This pull request has been merged in 179d2b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Interval midpoint calculations can overflow (integers). This fixes such an instance.
Test Plan: Standard test rig.
Differential Revision: D24392545