[doc] Fix info on the shape of pivots in torch.lu + more info on what and how they encode permutations.
#46844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaved
force-pushed
the
nikved/doc_fix_for_lu_pivots
branch
from
7fb0756
to
f1d0849
Compare
nikitaved
added
the
module: docs
nikitaved
changed the title
torch.lu + more info on what and how they encode permutations.torch.lu + more info on what and how they encode permutations.
izdeby
requested review from
vishwakftw and
malfet
and removed request for
vishwakftw
izdeby
added
the
triaged
nikitaved
force-pushed
the
nikved/doc_fix_for_lu_pivots
branch
2 times, most recently
from
0d47a58
to
cce1089
Compare
vishwakftw
reviewed
Oct 26, 2020
torch/functional.py
Outdated
| - **pivots** (*IntTensor*): the pivots of size :math:`(*, min(m, n))`. | ||
| ``pivots`` stores all the intermediate transpositions of rows. | ||
| The final permutation ``perm`` could be reconstructed by | ||
| applying :math:`swap(perm[i], perm[pivots[i] - 1])` for :math:`i = 0, \ldots, pivots.size(-1) - 1`, |
There was a problem hiding this comment.
swap, perm and pivots could be in \text{}, otherwise they'll be formatting like math.
There was a problem hiding this comment.
replaced with to replicate the code insertion.
nikitaved
force-pushed
the
nikved/doc_fix_for_lu_pivots
branch
from
cce1089
to
68e1f41
Compare
vishwakftw
approved these changes
Oct 28, 2020
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.