Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] fix bug in miopen findAlgorithm. #46852

Closed

Conversation

jeffdaily
Copy link
Collaborator

findAlgorithm should return if and only if a suitable algorithm is found.
The default algorithm is not guaranteed to have been cached.

findAlgorithm should return if and only if a suitable algorithm is found.
The default algorithm is not guaranteed to have been cached.
@jeffdaily jeffdaily added the module: rocm AMD GPU support for Pytorch label Oct 26, 2020
@jeffdaily
Copy link
Collaborator Author

@bhosmer please review. This should unblock your #45544.

@izdeby izdeby requested a review from bhosmer October 26, 2020 17:10
@izdeby izdeby added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 26, 2020
Copy link
Contributor

@bhosmer bhosmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeffdaily!

@dr-ci
Copy link

dr-ci bot commented Oct 26, 2020

💊 CI failures summary and remediations

As of commit 4d921e5 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_build

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@jeffdaily
Copy link
Collaborator Author

ROCm CI failed on a flaky test, not related to this change.

@jeffdaily
Copy link
Collaborator Author

@pytorchbot retest this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhosmer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bhosmer merged this pull request in a602811.

@jithunnair-amd jithunnair-amd deleted the upstream_fix_miopen_findAlgorithm branch May 12, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: rocm AMD GPU support for Pytorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants