Add NCCL_ASYNC_ERROR_HANDLING to docs #46856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
osalpekar
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
osalpekar
added a commit
that referenced
this pull request
Oct 26, 2020
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) ghstack-source-id: 115161174 Pull Request resolved: #46856
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
mrshenli
reviewed
Oct 26, 2020
jiayisuse
reviewed
Oct 26, 2020
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Oct 26, 2020
Pull Request resolved: #46856 Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. ghstack-source-id: 115176836 Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/)
jiayisuse
approved these changes
Oct 26, 2020
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Oct 26, 2020
Pull Request resolved: #46856 Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. ghstack-source-id: 115186877 Differential Revision: [D24541822](https://our.internmc.facebook.com/intern/diff/D24541822/)
osalpekar
added a commit
to osalpekar/pytorch
that referenced
this pull request
Oct 26, 2020
Summary: Pull Request resolved: pytorch#46856 Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. ghstack-source-id: 115186877 Test Plan: CI, verifying docs change Reviewed By: jiayisuse Differential Revision: D24541822 fbshipit-source-id: a0b3e843bc6392d2787a4bb270118f2dfda5f4ec
This was referenced Oct 26, 2020
|
This pull request has been merged in 5e2f17d. |
seemethere
pushed a commit
that referenced
this pull request
Oct 27, 2020
Summary: Pull Request resolved: #46856 Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs, similar to how NCCL_BLOCKING_WAIT is curently described. ghstack-source-id: 115186877 Test Plan: CI, verifying docs change Reviewed By: jiayisuse Differential Revision: D24541822 fbshipit-source-id: a0b3e843bc6392d2787a4bb270118f2dfda5f4ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add reference to NCCL_ASYNC_ERROR_HANDLING in the pytorch docs,
similar to how NCCL_BLOCKING_WAIT is curently described.
Differential Revision: D24541822