New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CUDA support for complex input for torch.triangular_solve #46916
Added CUDA support for complex input for torch.triangular_solve #46916
Conversation
💊 CI failures summary and remediationsAs of commit 129e93d (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 19 times. |
535bdc0
to
986c3fe
Compare
Hi @IvanYashchuk! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #46916 +/- ##
=======================================
Coverage 81.22% 81.23%
=======================================
Files 1836 1836
Lines 197896 197896
=======================================
+ Hits 160750 160752 +2
+ Misses 37146 37144 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @IvanYashchuk !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@IvanYashchuk can you rebase and resolve the merge conflict? |
@anjali411, I resolved the merge conflict. |
@anjali411, I updated this PR, should be ready for merge now. After that, the next PR on the list is |
@IvanYashchuk #47595 is merged, so let's get this in now. let me know when you have rebased and resolved the merge conflicts |
Hey @anjali411, merge conflicts were resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@anjali411 merged this pull request in 52ec8b9. |
torch.triangular_solve
now works for complex inputs on GPU.I moved the existing tests to
test_linalg.py
and modified them to test complex and float32 dtypes.Ref. #33152