Fix CPUCaching allocator guard bug #46922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D24566514 |
Summary: Pull Request resolved: pytorch#46922 Earlier bug wrongly captures the previous value to be saved. Test Plan: cpu_caching_allocator_test Reviewed By: dreiss Differential Revision: D24566514 fbshipit-source-id: 8b4ee6ed7a3c6a0c6b6a4aa1e50ce14e94d2eee6
|
This pull request was exported from Phabricator. Differential Revision: D24566514 |
kimishpatel
force-pushed
the
export-D24566514
branch
from
2a18f65
to
cfc8269
Compare
Codecov Report
@@ Coverage Diff @@
## master #46922 +/- ##
=======================================
Coverage 68.94% 68.94%
=======================================
Files 434 434
Lines 56188 56188
=======================================
+ Hits 38740 38741 +1
+ Misses 17448 17447 -1 |
|
This pull request has been merged in cbf90da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Earlier bug wrongly captures the previous value to be saved.
Test Plan: cpu_caching_allocator_test
Reviewed By: dreiss
Differential Revision: D24566514