Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jit] Prevent caching of graph attribute. #46960

Closed
wants to merge 1 commit into from
Closed

Conversation

bwasti
Copy link
Contributor

@bwasti bwasti commented Oct 27, 2020

graph is automatically cached even when the underlying graph changes -- this PR hardcodes a fix to that.

`graph` is automatically cached even when the underlying graph changes -- this PR hardcodes a fix to that.
@bwasti bwasti requested a review from apaszke as a code owner October 27, 2020 23:40
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 27, 2020
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwasti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #46960 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #46960   +/-   ##
=======================================
  Coverage   68.95%   68.95%           
=======================================
  Files         434      434           
  Lines       56199    56199           
=======================================
  Hits        38752    38752           
  Misses      17447    17447           

@facebook-github-bot
Copy link
Contributor

@bwasti merged this pull request in ddbdbce.

@facebook-github-bot facebook-github-bot deleted the bwasti-patch-1 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants