Correctly mark unannotated NamedTuple field to be inferred TensorType #46969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tugsbayasgalan
changed the title
💊 CI failures summary and remediationsAs of commit b059224 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 21 times. |
tugsbayasgalan
force-pushed
the
master
branch
2 times, most recently
from
bad0b00
to
2947832
Compare
gmagogsfm
reviewed
Oct 28, 2020
tugsbayasgalan
force-pushed
the
master
branch
2 times, most recently
from
2a2bd4b
to
6ecfa64
Compare
gmagogsfm
reviewed
Oct 28, 2020
tugsbayasgalan
force-pushed
the
master
branch
from
6ecfa64
to
57bf21f
Compare
tugsbayasgalan
force-pushed
the
master
branch
from
57bf21f
to
115b9db
Compare
Summary: If there is no annotation given, we want to show users that the type is inferred Test Plan: Added a new test case that throws an error with the expected error message Reviewers: Yanan Cao Subscribers: Tasks: pytorch#46326 Tags:
tugsbayasgalan
force-pushed
the
master
branch
from
115b9db
to
b059224
Compare
gmagogsfm
changed the title
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #46969 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 435 435
Lines 56309 56309
=======================================
Hits 38790 38790
Misses 17519 17519 |
gmagogsfm
approved these changes
Oct 29, 2020
|
@gmagogsfm merged this pull request in fee585b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If there is no annotation given, we want to show users that the type is inferred
Test Plan: Added a new test case that throws an error with the expected error message
Reviewers: Yanan Cao
Subscribers:
Tasks:
Tags:
Fixes #46326