fp16 -> fp32 EmbeddingBag moved into CPU impl #47076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Eliminate double casting in glow when submitting fp16 per sample weights Test Plan: buck test glow/glow/torch_glow/tests:embedding_bag_test Reviewed By: allwu Differential Revision: D24421367 fbshipit-source-id: 69bf37925a3b0595cedd78a16b823198d3d57e82
|
This pull request was exported from Phabricator. Differential Revision: D24421367 |
Codecov Report
@@ Coverage Diff @@
## master #47076 +/- ##
==========================================
- Coverage 68.85% 68.85% -0.01%
==========================================
Files 436 436
Lines 56395 56395
==========================================
- Hits 38833 38832 -1
- Misses 17562 17563 +1 |
|
This pull request has been merged in 7b8bd91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Eliminate double casting in glow when submitting fp16 per sample weights
Test Plan: buck test glow/glow/torch_glow/tests:embedding_bag_test
Reviewed By: allwu
Differential Revision: D24421367