Correctly print out sign of near-zero double values #47081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tugsbayasgalan
force-pushed
the
master
branch
2 times, most recently
from
00fe653
to
b04d752
Compare
tugsbayasgalan
changed the title
💊 CI failures summary and remediationsAs of commit d530d3e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 28 times. |
tugsbayasgalan
force-pushed
the
master
branch
4 times, most recently
from
aa2285c
to
7e5dc71
Compare
gmagogsfm
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
tugsbayasgalan
force-pushed
the
master
branch
from
7e5dc71
to
d530d3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #47081 +/- ##
=======================================
Coverage 60.81% 60.81%
=======================================
Files 2748 2748
Lines 254047 254048 +1
=======================================
+ Hits 154503 154505 +2
+ Misses 99544 99543 -1 |
gmagogsfm
changed the title
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gmagogsfm merged this pull request in 29184f8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: inside IValue.h, we previously printed -0.0 as 0.0. Therefore, it was causing some inconsistency when using -0.0.
Test Plan: A new test case inside test_jit that divides a tensor by -0. and checks if it outputs -inf for all modes.
Reviewers: Yanan Cao
Subscribers:
Tasks:
Tags:
Fixes #46848