New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Update batch_norm symbolic to handle track_running_stats=False #47135
[ONNX] Update batch_norm symbolic to handle track_running_stats=False #47135
Conversation
…kare/batch-norm-running-stats
…kare/batch-norm-running-stats
💊 CI failures summary and remediationsAs of commit 9c671ce (more details on the Dr. CI page):
ci.pytorch.org: 1 failedcodecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor comments.
…kare/batch-norm-running-stats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…kare/batch-norm-running-stats
Codecov Report
@@ Coverage Diff @@
## master #47135 +/- ##
==========================================
- Coverage 81.46% 81.46% -0.01%
==========================================
Files 1792 1792
Lines 186196 186202 +6
==========================================
+ Hits 151680 151682 +2
- Misses 34516 34520 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The tests added in this PR are failing CI: https://app.circleci.com/pipelines/github/pytorch/pytorch/237272/workflows/aee4f636-ef8c-4c93-bab1-a135517016eb/jobs/8822526
we'll revert this PR, but please feel free to fix and resubmit it. |
Fixes #45333