Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update batch_norm symbolic to handle track_running_stats=False #47135

Conversation

shubhambhokare1
Copy link
Collaborator

Fixes #45333

@dr-ci
Copy link

dr-ci bot commented Oct 30, 2020

💊 CI failures summary and remediations

As of commit 9c671ce (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

@ngimel ngimel requested a review from bzinodev November 1, 2020 04:37
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 1, 2020
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor comments.

torch/onnx/symbolic_opset9.py Show resolved Hide resolved
test/onnx/test_pytorch_onnx_onnxruntime.py Show resolved Hide resolved
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #47135 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #47135      +/-   ##
==========================================
- Coverage   81.46%   81.46%   -0.01%     
==========================================
  Files        1792     1792              
  Lines      186196   186202       +6     
==========================================
+ Hits       151680   151682       +2     
- Misses      34516    34520       +4     

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zou3519
Copy link
Contributor

zou3519 commented Nov 10, 2020

The tests added in this PR are failing CI: https://app.circleci.com/pipelines/github/pytorch/pytorch/237272/workflows/aee4f636-ef8c-4c93-bab1-a135517016eb/jobs/8822526

Nov 10 21:28:44 =========================== short test summary info ============================
Nov 10 21:28:44 FAILED test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_batchnorm1d_norunningstats
Nov 10 21:28:44 FAILED test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_batchnorm2d_norunningstats

we'll revert this PR, but please feel free to fix and resubmit it.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 1a55f5b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONNX export fails for BatchNormalization with track_running_stats=False
7 participants