Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[numpy] torch.a{cosh, sinh} : promote integer inputs to float #47152

Conversation

kshitij12345
Copy link
Collaborator

Reference #42515

@facebook-github-bot
Copy link
Contributor

Hi @kshitij12345!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #47152 into master will increase coverage by 12.38%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #47152       +/-   ##
===========================================
+ Coverage   48.43%   60.82%   +12.38%     
===========================================
  Files        2735     2748       +13     
  Lines      252164   254040     +1876     
===========================================
+ Hits       122140   154509    +32369     
+ Misses     130024    99531    -30493     

@ngimel ngimel requested a review from mruberry November 1, 2020 04:40
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 1, 2020
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kshitij12345!

Let me know when you get a chance to sign the CLA.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kshitij12345
Copy link
Collaborator Author

@mruberry The CLA is signed. The comment is stale. Thanks!

@dr-ci
Copy link

dr-ci bot commented Nov 2, 2020

💊 CI failures summary and remediations

As of commit 8879b37 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry
Copy link
Collaborator

mruberry commented Nov 2, 2020

The lint failure is spurious. Sorry about that, @kshitij12345. It won't prevent merging.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 6397855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants