New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[numpy] torch.a{cosh, sinh}
: promote integer inputs to float
#47152
[numpy] torch.a{cosh, sinh}
: promote integer inputs to float
#47152
Conversation
Hi @kshitij12345! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #47152 +/- ##
===========================================
+ Coverage 48.43% 60.82% +12.38%
===========================================
Files 2735 2748 +13
Lines 252164 254040 +1876
===========================================
+ Hits 122140 154509 +32369
+ Misses 130024 99531 -30493 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kshitij12345!
Let me know when you get a chance to sign the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@mruberry The CLA is signed. The comment is stale. Thanks! |
💊 CI failures summary and remediationsAs of commit 8879b37 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The lint failure is spurious. Sorry about that, @kshitij12345. It won't prevent merging. |
Reference #42515