Add input argument to autograd.backward() cpp api
#47214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge_backward_api
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit b8abed0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
Codecov Report
@@ Coverage Diff @@
## master #47214 +/- ##
=======================================
Coverage 60.82% 60.82%
=======================================
Files 2748 2748
Lines 254055 254079 +24
=======================================
+ Hits 154519 154538 +19
- Misses 99536 99541 +5 |
albanD
reviewed
Nov 3, 2020
soulitzer
changed the title
input argument to autograd.backward() cpp api
soulitzer
requested review from
apaszke,
ebetica,
glaringlee,
goldsborough and
yf225
as code owners
There was a problem hiding this comment.
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@soulitzer merged this pull request in 2e5bfa9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps fix #46373 for the cpp api.
Follow up to #46855 which only changed the api for python only