Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs/test for dot and vdot #47242

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Nov 2, 2020

Stack from ghstack:

Differential Revision: D24733771

heitorschueroff added a commit that referenced this pull request Nov 2, 2020
ghstack-source-id: e2e8004350bf07cc42eab30cf1a7e861716eecde
Pull Request resolved: #47242
@dr-ci
Copy link

dr-ci bot commented Nov 2, 2020

💊 CI failures summary and remediations

As of commit ddb4403 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_xenial_py3_clang7_onnx_ort_test1

codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

test/test_linalg.py Outdated Show resolved Hide resolved
test/test_linalg.py Outdated Show resolved Hide resolved
test/test_linalg.py Outdated Show resolved Hide resolved
test/test_linalg.py Outdated Show resolved Hide resolved
test/test_linalg.py Outdated Show resolved Hide resolved
torch/_torch_docs.py Outdated Show resolved Hide resolved
torch/_torch_docs.py Outdated Show resolved Hide resolved
@mruberry mruberry self-requested a review November 4, 2020 18:30
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I made one final consistency comment on the docs. Should be very easy to address.

heitorschueroff added a commit that referenced this pull request Nov 4, 2020
ghstack-source-id: 69cc1a0e7fc1338b9818c7f61b950fb9f583d22f
Pull Request resolved: #47242
@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in a4ba018.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/25/head branch November 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants