[quant][graphmode][fx] Add support for qat convbn{relu}1d #47248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
approved these changes
Nov 3, 2020
|
ok, I think we can change the test to test numerics too |
💊 CI failures summary and remediationsAs of commit 1afb939 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 30 times. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 3, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d5390f4890c1d35de7af5828df23cf365fd4e452 Pull Request resolved: #47248
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 3, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 42c0043f3593b21fbd33ce36f2e3916fa9d4e8a7 Pull Request resolved: #47248
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 3, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 11f606055264063f2cd7ef4baff18e3ca6b50995 Pull Request resolved: #47248
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24696524](https://our.internmc.facebook.com/intern/diff/D24696524) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 4, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4468f1f185227675477a3207e8b82c2a9967151a Pull Request resolved: #47248
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/487/base #47248 +/- ##
=======================================================
Coverage 60.81% 60.82%
=======================================================
Files 2749 2749
Lines 254098 254126 +28
=======================================================
+ Hits 154536 154562 +26
- Misses 99562 99564 +2 |
|
This pull request has been merged in 0cba3e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24696524