Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulkan reshape op (hack) #47252

Closed
wants to merge 4 commits into from
Closed

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Nov 3, 2020

For now, just use the CPU to reshape.

Stack from ghstack:

Differential Revision: D24733906

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Nov 3, 2020
ghstack-source-id: e77957d24a2512e97e3fd7342dceb86e39842c16
Pull Request resolved: #47252
@SS-JIA SS-JIA changed the title Add vulkan shape op (hack) Add vulkan reshape op (hack) Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #47252 into gh/SS-JIA/2/base will increase coverage by 24.80%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           gh/SS-JIA/2/base   #47252       +/-   ##
=====================================================
+ Coverage             36.03%   60.83%   +24.80%     
=====================================================
  Files                   438     2748     +2310     
  Lines                 55320   254096   +198776     
=====================================================
+ Hits                  19932   154572   +134640     
- Misses                35388    99524    +64136     

@SS-JIA SS-JIA requested review from IvanKobzarev and AshkanAliabadi and removed request for IvanKobzarev November 4, 2020 18:17
@dr-ci
Copy link

dr-ci bot commented Nov 4, 2020

💊 CI failures summary and remediations

As of commit 079db2e (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_6_gcc5_4_test Download Docker image 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

For now, just use the CPU to reshape.




[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Nov 4, 2020
ghstack-source-id: dc03d44a6151091a0911fe21a493b29b92d287cc
Pull Request resolved: #47252
@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 5d82311.

@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/2/head branch November 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants