[jit] better message for bad type annotation #47464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D24764886 |
facebook-github-bot
added
the
oncall: jit
ppwwyyxx
requested review from
SplitInfinity and
eellison
and removed request for
apaszke
|
ah the PR still has unrelated contents from a different PR.. but the diff is clean |
There was a problem hiding this comment.
It seems that this is stacked on top of #45645 - if you unstack I think we can land this separately.
Summary: Pull Request resolved: pytorch#47464 ``` ValueError: Unknown type annotation: 'typing.Sequence[torch.Tensor]' at File "xxx.py", line 223 images = [x["image"].to(self.device) for x in batched_inputs] images = [(x - self.pixel_mean) / self.pixel_std for x in images] images = ImageList.from_tensors(images, self.backbone.size_divisibility) ~~~~~~~~~~~~~~~~~~~~~~ <--- HERE return images ``` Otherwise have no clue where the error is. Test Plan: sandcastle Differential Revision: D24764886 fbshipit-source-id: b28de389024c447b59eafd0b654d792fd3b15961
|
This pull request was exported from Phabricator. Differential Revision: D24764886 |
ppwwyyxx
force-pushed
the
export-D24764886
branch
from
d938abd
to
1434e25
Compare
SplitInfinity
approved these changes
Nov 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #47464 +/- ##
=======================================
Coverage 81.44% 81.45%
=======================================
Files 1798 1798
Lines 188223 188223
=======================================
+ Hits 153306 153309 +3
+ Misses 34917 34914 -3 |
|
This pull request has been merged in 24b549b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Otherwise have no clue where the error is.
Test Plan: sandcastle
Differential Revision: D24764886