Fix type annotation errors in torch.distributed.* directory #47531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory. Test Plan: python test_type_hints.py -v TestTypeHints.test_run_mypy Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
xuzhao9
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
This was referenced Nov 6, 2020
💊 CI failures summary and remediationsAs of commit 2981ef2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 19 times. |
xuzhao9
commented
Nov 6, 2020
| @@ -97,6 +98,11 @@ PyObject* faulty_agent_init(PyObject* _unused, PyObject* noargs) { | |||
| (const WorkerInfo& (ProcessGroupAgent::*)(const std::string&)const) & | |||
| ProcessGroupAgent::getWorkerInfo, | |||
| py::call_guard<py::gil_scoped_release>()) | |||
| .def( | |||
There was a problem hiding this comment.
Have to import this function, otherwise mypy will report in class FaultyProcessGroupRpcBackendOptions, "get_worker_info" has different signature than its super class.
xuzhao9
requested review from
malfet and
walterddr
and removed request for
pietern,
apaszke,
rohan-varma,
pritamdamania87,
mrshenli,
mingzhe09088 and
zhaojuanmao
malfet
approved these changes
Nov 10, 2020
walterddr
reviewed
Nov 10, 2020
walterddr
approved these changes
Nov 10, 2020
Summary: This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory. Test Plan: python test_type_hints.py -v TestTypeHints.test_run_mypy Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory. Test Plan: python test_type_hints.py -v TestTypeHints.test_run_mypy Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory. Test Plan: python test_type_hints.py -v TestTypeHints.test_run_mypy Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24952499](https://our.internmc.facebook.com/intern/diff/D24952499) [ghstack-poisoned]
Summary: This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory. Test Plan: python test_type_hints.py -v TestTypeHints.test_run_mypy Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24952499](https://our.internmc.facebook.com/intern/diff/D24952499) [ghstack-poisoned]
|
This pull request has been merged in 49eb82a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is part of a stack of PRs that fixes mypy typing errors in the torch.distributed.* directory.
Test Plan:
python test_type_hints.py -v TestTypeHints.test_run_mypy
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24952499