New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagflat complex support #47564
Add diagflat complex support #47564
Conversation
Add complex support for torch.diagflat cpu
💊 CI failures summary and remediationsAs of commit 5917c83 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet: This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
@rjkilpatrick is this PR ready for review? |
@anjali411 this issue is ready to be reviewed. The complex autograd should be a separate issue. |
@albanD can you please advise whether we can leave autograd support for a later PR? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@anjali411 merged this pull request in 8aca85d. |
@anjali411 the autograd should be disabled anyways as it is not in the whitelist right? |
@albanD |
Adds complex numbers support for
torch.diag
Note that automatic differentiation isn't implemented:
Fixes #47499