New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kthvalue error for scalar input #47600
Fix kthvalue error for scalar input #47600
Conversation
[ghstack-poisoned]
ghstack-source-id: 9d76cfaa6d26d1ddd835718342749f5487dc3e1e Pull Request resolved: #47600
💊 CI failures summary and remediationsAs of commit bc871c9 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small note about improving the comment, but you also have some failing tests as a result of this change.
ghstack-source-id: 393880d63a051d07d83378b960124106f0561f6b Pull Request resolved: #47600
fixes #30818 Note that the median case was already fixed by #45847 Differential Revision: [D24860337](https://our.internmc.facebook.com/intern/diff/D24860337) [ghstack-poisoned]
ghstack-source-id: bf8bcb375a84f81125a3667b4eb8d337b55f3128 Pull Request resolved: #47600
@heitorschueroff merged this pull request in bf6a156. |
1 similar comment
@heitorschueroff merged this pull request in bf6a156. |
Stack from ghstack:
fixes #30818
Note that the median case was already fixed by #45847
Differential Revision: D24860337