Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kthvalue error for scalar input #47600

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Nov 9, 2020

Stack from ghstack:

fixes #30818

Note that the median case was already fixed by #45847

Differential Revision: D24860337

heitorschueroff added a commit that referenced this pull request Nov 9, 2020
ghstack-source-id: 9d76cfaa6d26d1ddd835718342749f5487dc3e1e
Pull Request resolved: #47600
@dr-ci
Copy link

dr-ci bot commented Nov 9, 2020

💊 CI failures summary and remediations

As of commit bc871c9 (more details on the Dr. CI page):


  • 3/3 failures possibly* introduced in this PR
    • 2/3 non-CircleCI failure(s)

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.


ci.pytorch.org: 2 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 14 times.

test/test_torch.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small note about improving the comment, but you also have some failing tests as a result of this change.

@mruberry mruberry self-requested a review November 10, 2020 04:45
fixes #30818

Note that the median case was already fixed by #45847

[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Nov 10, 2020
ghstack-source-id: 393880d63a051d07d83378b960124106f0561f6b
Pull Request resolved: #47600
fixes #30818

Note that the median case was already fixed by #45847

Differential Revision: [D24860337](https://our.internmc.facebook.com/intern/diff/D24860337)

[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Nov 10, 2020
ghstack-source-id: bf8bcb375a84f81125a3667b4eb8d337b55f3128
Pull Request resolved: #47600
@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in bf6a156.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in bf6a156.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/26/head branch November 14, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants