[GPU] Make permuteWeights inline #47634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on @dust's diff - D24710102. Make the function inline in order to get rid of the compiler checking `-Werror,-Wunused-function`. Differential Revision: [D24824637](https://our.internmc.facebook.com/intern/diff/D24824637/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 1711d57 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
Follow up on @dust's diff - D24710102. Make the function inline in order to get rid of the compiler checking `-Werror,-Wunused-function`. Differential Revision: [D24824637](https://our.internmc.facebook.com/intern/diff/D24824637/) [ghstack-poisoned]
husthyc
approved these changes
Nov 12, 2020
Follow up on @dust's diff - D24710102. Make the function inline in order to get rid of the compiler checking `-Werror,-Wunused-function`. Differential Revision: [D24824637](https://our.internmc.facebook.com/intern/diff/D24824637/) [ghstack-poisoned]
|
This pull request has been merged in 2ed3430. |
tugsbayasgalan
pushed a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Nov 16, 2020
Summary: Pull Request resolved: pytorch#47634 Follow up on d16r's diff - D24710102. Make the function inline in order to get rid of the compiler checking `-Werror,-Wunused-function`. ghstack-source-id: 116607200 Test Plan: 1. Sandcastle Tests 2. CircleCI jobs Reviewed By: d16r Differential Revision: D24824637 fbshipit-source-id: c17e219b384b91ac4620aa23112a6cda1200a605
jasperzhong
pushed a commit
to jasperzhong/swift
that referenced
this pull request
Nov 25, 2021
Pull Request resolved: pytorch/pytorch#47634 Follow up on @dust's diff - D24710102. Make the function inline in order to get rid of the compiler checking `-Werror,-Wunused-function`. ghstack-source-id: 116607200 Differential Revision: [D24824637](https://our.internmc.facebook.com/intern/diff/D24824637/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Follow up on @dust's diff - D24710102. Make the function inline in order to get rid of the compiler checking
-Werror,-Wunused-function.Differential Revision: D24824637