[Docs] Minor doc fixes for init_process_group #47644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor Update to the init_process_group docs. Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/) [ghstack-poisoned]
osalpekar
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
osalpekar
added a commit
that referenced
this pull request
Nov 10, 2020
Minor Update to the init_process_group docs. Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/) ghstack-source-id: 116258381 Pull Request resolved: #47644
mrshenli
approved these changes
Nov 10, 2020
| @@ -401,11 +401,11 @@ def init_process_group(backend, | |||
| asynchronously and the process will crash. ``NCCL_BLOCKING_WAIT`` | |||
| will provide errors to the user which can be caught and handled, | |||
| but due to its blocking nature, it has a performance overhead. On | |||
| the other hand, ``NCCL_ASYNC_ERROR_HANDLING`` has little | |||
| the other hand, ``NCCL_ASYNC_ERROR_HANDLING`` has very little | |||
There was a problem hiding this comment.
redundant space before "very"
💊 CI failures summary and remediationsAs of commit 15549e7 (more details on the Dr. CI page):
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Minor Update to the init_process_group docs. Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Nov 10, 2020
Pull Request resolved: #47644 Minor Update to the init_process_group docs. ghstack-source-id: 116337449 Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/)
Minor Update to the init_process_group docs. Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Nov 11, 2020
Pull Request resolved: #47644 Minor Update to the init_process_group docs. ghstack-source-id: 116441798 Differential Revision: [D24633432](https://our.internmc.facebook.com/intern/diff/D24633432/)
|
This pull request has been merged in 32b4b51. |
|
This pull request has been merged in 32b4b51. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Minor Update to the init_process_group docs.
Differential Revision: D24633432