add basic to_one_hot function #4774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justheuristic
changed the title
justheuristic
changed the title
|
@pytorchbot c'mon, do something :) |
|
@justheuristic can you add a test to test_nn.py (see other tests for functional, but can be something simple: give known input and check for known result). Also, add an entry to: https://github.com/pytorch/pytorch/blob/master/docs/source/nn.rst |
|
Sorry for the delay. Added simple test case and autodoc. |
|
Almighty @pytorchbot , help me again! |
|
@pytorchbot test this please |
|
Test failures are legit |
|
i wonder if i can do that too |
|
@pytorchbot test this please |
1 similar comment
|
@pytorchbot test this please |
justheuristic
requested review from
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
weiyangfb
reviewed
Aug 14, 2018
| 0 0 1 | ||
| [torch.FloatTensor of size 3x2x3] | ||
| """ | ||
| y_tensor = y.data if isinstance(y, Variable) else y |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
weiyangfb
added
the
awaiting response (this tag is deprecated)
|
Sorry for missing this @justheuristic. We merged a one_hot implementation in #15208; thank you for your PR nonetheless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This may be covered in some pending pull-request, but if it isn't, here's a simple one-hot function from my collection of pytorch helpers that may or may not be useful :)
It essentially copies this issue.