Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]: Correct docs for torch.lu_solve #47762

Closed
wants to merge 1 commit into from

Conversation

bharatr21
Copy link
Contributor

Fixes #43498 by correcting the function signature of torch.lu_solve

@dr-ci
Copy link

dr-ci bot commented Nov 11, 2020

💊 CI failures summary and remediations

As of commit 9037d65 (more details on the Dr. CI page):


  • 1/4 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 3/4 broken upstream at merge base 88ec72e since Nov 11

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet:


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in 3aeb9cc.

@kshitij12345
Copy link
Collaborator

I think,
The input argument b in the docs should be changed to input.

>>> A = torch.randn(2, 3, 3)
>>> b = torch.randn(2, 3, 1)
>>> A_LU = torch.lu(A)
>>> x = torch.lu_solve(b, *A_LU)
>>> torch.lu_solve(input=b, LU_data=A_LU[0], LU_pivots=A_LU[1])
tensor([[[ 2.0788],
         [ 0.1862],
         [ 2.7321]],

        [[ 1.7038],
         [ 1.7400],
         [-3.2406]]])
>>> torch.lu_solve(b=b, LU_data=A_LU[0], LU_pivots=A_LU[1])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: lu_solve() missing 3 required positional argument: "input", "LU_data", "LU_pivots"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch.lu_solve documentation refers b as an argument.
5 participants