Properly serialize types that only appear at function input

[suo]

Stack from ghstack:

• Properly serialize types that only appear at function input #47775 Properly serialize types that only appear at function input

When serializing graphs, we check every node for named types referenced,
so that we can register them as dependencies. We were skipping this
check for the graph inputs themselves. Since types used at input are
almost always used somewhere in the graph, we never noticed this gap
until a user reported an issue with NamedTuples.

Differential Revision: D24896289

[jamesr66a]

What about at the output? I can sneakily construct a counterexample like so:

import torch
from typing import NamedTuple, Optional

class Point(NamedTuple):
  x : int
  y : int

class Foo(torch.nn.Module):
  def __init__(self):
    super().__init__()

  def forward(self) -> Optional[Point]:
    return None

script = torch.jit.script(Foo())
torch.jit.save(script, 'foo.zip')
torch.jit.load('foo.zip')

"""
RuntimeError: 
Unknown type name '__torch__.Point':
Serialized   File "code/__torch__.py", line 5
  __buffers__ = []
  training : bool
  def forward(self: __torch__.Foo) -> Optional[__torch__.Point]:
                                               ~~~~~~~~~~~~~~~ <--- HERE
    return None


"""

[dr-ci]

💊 CI failures summary and remediations

As of commit b540718 (more details on the Dr. CI page):

---

• 1/3 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)
• 2/3 broken upstream at merge base 4cb73f5 on Nov 11 from 12:30am to 11:54am PDT (12 commits; 0650a61 - dac0192)

---

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 on Nov 11 from 12:30am to 11:54am PDT (12 commits; 0650a61 - dac0192)
  • 🔁 rerun
• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 on Nov 11 from 12:30am to 11:54am PDT (12 commits; 0650a61 - dac0192)
  • 🔁 rerun

---

ci.pytorch.org: 1 failed

• Failed: pr/pytorch-linux-bionic-rocm3.9-py3.6

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

[jamesr66a]

[facebook-github-bot]

@suo merged this pull request in d4fa84b.

[facebook-github-bot]

@suo merged this pull request in d4fa84b.