Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Remove unnecessary shared_ptr copies in ThreadLocalDebugInfo::get #47791

Closed
wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Nov 11, 2020

Stack from ghstack:

debug_info is thread_local and this function is a leaf, so nobody else could free it out from under us. Regular pointer should be fine.

Differential Revision: D24901749

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

…o::get

`debug_info` is `thread_local` and this function is a leaf, so nobody else could free it out from under us. Regular pointer should be fine.

Differential Revision: [D24901749](https://our.internmc.facebook.com/intern/diff/D24901749/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24901749/)!

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Nov 11, 2020
…o::get

`debug_info` is `thread_local` and this function is a leaf, so nobody else could free it out from under us. Regular pointer should be fine.

Differential Revision: [D24901749](https://our.internmc.facebook.com/intern/diff/D24901749/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24901749/)!

ghstack-source-id: 116456975
Pull Request resolved: #47791
@dr-ci
Copy link

dr-ci bot commented Nov 11, 2020

💊 CI failures summary and remediations

As of commit c9188c1 (more details on the Dr. CI page):


  • 1/3 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 2/3 broken upstream at merge base 5647f0c on Nov 11 from 12:30am to 11:54am PDT (12 commits; 0650a61 - dac0192)

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1aeac97.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/13/head branch November 16, 2020 15:17
tugsbayasgalan pushed a commit to tugsbayasgalan/pytorch that referenced this pull request Nov 16, 2020
…o::get (pytorch#47791)

Summary:
Pull Request resolved: pytorch#47791

`debug_info` is `thread_local` and this function is a leaf, so nobody else could free it out from under us. Regular pointer should be fine.
ghstack-source-id: 116456975

Test Plan: Run framework overhead benchmarks

Reviewed By: bhosmer

Differential Revision: D24901749

fbshipit-source-id: c01a60b609fd08e5200264d8e98d356e2c78cf28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants