Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Enable prepacked addmm for linear layers #47815

Closed
wants to merge 4 commits into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Nov 12, 2020

Stack from ghstack:

Differential Revision: D24908605

@SS-JIA SS-JIA requested a review from apaszke as a code owner November 12, 2020 00:49
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 12, 2020
@dr-ci
Copy link

dr-ci bot commented Nov 12, 2020

💊 CI failures summary and remediations

As of commit 6d9cc38 (more details on the Dr. CI page):


  • 1/3 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 2/3 broken upstream at merge base ae5c2fe on Nov 11 from 12:30am to 11:54am PDT (12 commits; 0650a61 - dac0192)

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 16 times.

SS-JIA added a commit that referenced this pull request Nov 12, 2020
ghstack-source-id: 007f0665472ea3e7771a45960fe6472f883201d3
Pull Request resolved: #47815
@SS-JIA SS-JIA changed the title [vulkan] Enable prepacked addmm/mm for linear layers [vulkan] Enable prepacked addmm for linear layers Nov 12, 2020
@SS-JIA SS-JIA marked this pull request as draft November 12, 2020 01:19
torch/csrc/jit/passes/vulkan_rewrite.cpp Outdated Show resolved Hide resolved
aten/src/ATen/native/vulkan/ops/Mm.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@AshkanAliabadi AshkanAliabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

aten/src/ATen/native/vulkan/ops/Mm.cpp Outdated Show resolved Hide resolved
aten/src/ATen/native/vulkan/ops/Mm.cpp Show resolved Hide resolved
aten/src/ATen/native/vulkan/ops/Mm.cpp Outdated Show resolved Hide resolved
torch/csrc/jit/passes/vulkan_rewrite.cpp Outdated Show resolved Hide resolved
torch/csrc/jit/passes/vulkan_rewrite.cpp Outdated Show resolved Hide resolved
SS-JIA added a commit that referenced this pull request Nov 12, 2020
ghstack-source-id: d7c3ec0485cc2df8f25a3b777bbaf388ff6fe0c8
Pull Request resolved: #47815
SS-JIA added a commit that referenced this pull request Nov 12, 2020
ghstack-source-id: 1d9864bd64bb59fba802061d40c5d55f0c1149c4
Pull Request resolved: #47815
@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in cfe3def.

@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/9/head branch November 16, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants