Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using lambda function as TorchBind constructor #47819

Closed
wants to merge 1 commit into from
Closed

Support using lambda function as TorchBind constructor #47819

wants to merge 1 commit into from

Conversation

gmagogsfm
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 12, 2020
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for doing this!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Nov 12, 2020

💊 CI failures summary and remediations

As of commit b821a59 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #47819 (b821a59) into master (febc76a) will increase coverage by 29.77%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           master   #47819       +/-   ##
===========================================
+ Coverage   42.09%   71.86%   +29.77%     
===========================================
  Files         471     1832     +1361     
  Lines       64610   197733   +133123     
===========================================
+ Hits        27198   142107   +114909     
- Misses      37412    55626    +18214     

@facebook-github-bot
Copy link
Contributor

@gmagogsfm merged this pull request in 00a3add.

tugsbayasgalan pushed a commit to tugsbayasgalan/pytorch that referenced this pull request Nov 16, 2020
…ytorch#47819)

Summary: Pull Request resolved: pytorch#47819

Reviewed By: wanchaol

Differential Revision: D24910065

Pulled By: gmagogsfm

fbshipit-source-id: ad5b4f67b0367e44fe486d31a060d9ad1e0cf568
@gmagogsfm gmagogsfm changed the title [TorchBind] Support using lambda function as TorchBind constructor Support using lambda function as TorchBind constructor Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants